Add a white list for deprecated timezone IDs #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ensure they are included in the timezone name to ID mapping. Alternatively we could use pytz.all_timezones instead of pytz.common_timezones but that adds a lot of noise to the name to ID mapping.
marcospri
commented
Dec 22, 2025
marcospri
commented
Dec 22, 2025
| # in the timezone name mapping (these are in pytz.all_timezones but not in | ||
| # pytz.common_timezones) | ||
| DEPRECATED_TIMEZONES_WHITELIST = [ | ||
| "Asia/Calcutta", # Now Asia/Kolkata (India) |
Contributor
Author
There was a problem hiding this comment.
I've seen "Asia/Calcutta" commonly used as an example for this
for example:
https://github.com/google/libphonenumber/tree/master/resources/timezones
- Use bash as a shell - Explicitly set set-safe-directory to true when checking out code
marcospri
force-pushed
the
check-tz-ids-match-names
branch
from
f800896 to
1e9ebaa
Compare
marcospri
commented
Dec 22, 2025
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Configure Git safe directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to ensure they are included in the timezone name to ID mapping.
Alternatively we could use pytz.all_timezones instead of pytz.common_timezones
but that adds a lot of noise to the name to ID mapping.